Conversation
Track v1.4-andium branch instead of pinning to exact v1.4.4 tag so point releases (v1.4.5, v1.4.6, ...) automatically rebuild the extension with matching platform strings. Add weekday scheduled builds. - Use duckdb/extension-ci-tools reusable _extension_distribution.yml - Add branch = main to .gitmodules for submodule tracking - Exclude wasm and untested platforms (gcc4, rtools, mingw) for now - Enable rust_logs for debugging initial runs
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 52e2695dde
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' && github.sha || '' }} | ||
| cancel-in-progress: true | ||
| group: ${{ github.workflow }}-${{ github.ref }}-${{ github.head_ref || '' }}-${{ github.base_ref || '' }}-${{ github.ref != 'refs/heads/main' || github.sha }} |
There was a problem hiding this comment.
The concurrency suffix now uses github.ref != 'refs/heads/main' || github.sha, which evaluates to the boolean true for every non-main run instead of a per-commit SHA. That collapses all runs on the same PR/branch into one concurrency group, and with cancel-in-progress: false they queue behind older runs rather than executing with the commit they were triggered for, delaying CI feedback on active branches.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ba0a2ace1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| uses: duckdb/extension-ci-tools/.github/workflows/_extension_distribution.yml@main | ||
| with: | ||
| duckdb_version: v1.4-andium | ||
| ci_tools_version: main |
There was a problem hiding this comment.
Pinning the stable job to duckdb_version: v1.4-andium while still calling _extension_distribution.yml@main with ci_tools_version: main mixes two different compatibility tracks and can break the “stable” build as soon as extension-ci-tools main drops or changes 1.4 behavior. The stable lane should use the matching v1.4-andium CI tooling reference so it remains reproducible and actually validates the 1.4 release line.
Useful? React with 👍 / 👎.
1 participant
v1.5-variegata)The example notebooks and README notebook docs now live in #25.